Skip to content

add discounting to LinUCB#685

Closed
alexnikulkov wants to merge 2 commits intofacebookresearch:mainfrom
alexnikulkov:export-D39929407
Closed

add discounting to LinUCB#685
alexnikulkov wants to merge 2 commits intofacebookresearch:mainfrom
alexnikulkov:export-D39929407

Conversation

@alexnikulkov
Copy link
Contributor

Summary: Mostly a copy of D39157916 for Joint LinUCB model

Differential Revision: D39929407

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D39929407

alexnik and others added 2 commits October 2, 2022 22:33
…and current_epoch

Differential Revision: D39929408

fbshipit-source-id: 8c469d28453858c04eb6885d5abee218c8dcee8d
Summary:
Pull Request resolved: facebookresearch#685

Mostly a copy of D39157916 for Joint LinUCB model

Differential Revision: D39929407

fbshipit-source-id: 1d2598db191fe2dd6172b3fb27c8c8ac7706daff
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D39929407

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Base: 87.52% // Head: 87.57% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (264be00) compared to base (5d90840).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #685      +/-   ##
==========================================
+ Coverage   87.52%   87.57%   +0.05%     
==========================================
  Files         365      365              
  Lines       23446    23531      +85     
  Branches       44       44              
==========================================
+ Hits        20521    20608      +87     
+ Misses       2899     2897       -2     
  Partials       26       26              
Impacted Files Coverage Δ
reagent/models/disjoint_linucb_predictor.py 95.74% <100.00%> (+0.39%) ⬆️
reagent/models/linear_regression.py 98.18% <100.00%> (+0.30%) ⬆️
reagent/test/training/cb/test_disjoint_linucb.py 100.00% <100.00%> (ø)
reagent/test/training/cb/test_linucb.py 100.00% <100.00%> (ø)
reagent/training/cb/disjoint_linucb_trainer.py 97.43% <100.00%> (ø)
reagent/training/cb/linucb_trainer.py 97.72% <100.00%> (+4.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

xuruiyang pushed a commit that referenced this pull request Sep 20, 2025
Summary:
Pull Request resolved: #685

Mostly a copy of D39157916 for Joint LinUCB model

Differential Revision: D39929407

fbshipit-source-id: 7566c00641f1b467c4d92a25d213ac7b0c9b4bbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants