Skip to content

fix recurrent training for LinUCB by splictting A,b between all_data and current_epoch#686

Closed
alexnikulkov wants to merge 1 commit intofacebookresearch:mainfrom
alexnikulkov:export-D39929408
Closed

fix recurrent training for LinUCB by splictting A,b between all_data and current_epoch#686
alexnikulkov wants to merge 1 commit intofacebookresearch:mainfrom
alexnikulkov:export-D39929408

Conversation

@alexnikulkov
Copy link
Contributor

Summary: A copy of D39902734 for joint LinUCB

Differential Revision: D39929408

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D39929408

…and current_epoch (facebookresearch#686)

Summary:
Pull Request resolved: facebookresearch#686

A copy of D39902734 for joint LinUCB

Differential Revision: D39929408

fbshipit-source-id: 7fd0c2303f5b75ada5664d93d8a7cb927e788b27
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D39929408

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Base: 87.52% // Head: 87.55% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (8ccd75a) compared to base (5d90840).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   87.52%   87.55%   +0.03%     
==========================================
  Files         365      365              
  Lines       23446    23487      +41     
  Branches       44       44              
==========================================
+ Hits        20521    20564      +43     
+ Misses       2899     2897       -2     
  Partials       26       26              
Impacted Files Coverage Δ
reagent/models/disjoint_linucb_predictor.py 95.74% <100.00%> (+0.39%) ⬆️
reagent/models/linear_regression.py 98.11% <100.00%> (+0.24%) ⬆️
reagent/test/training/cb/test_disjoint_linucb.py 100.00% <100.00%> (ø)
reagent/test/training/cb/test_linucb.py 100.00% <100.00%> (ø)
reagent/training/cb/disjoint_linucb_trainer.py 97.43% <100.00%> (ø)
reagent/training/cb/linucb_trainer.py 97.61% <100.00%> (+4.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

xuruiyang pushed a commit that referenced this pull request Sep 20, 2025
…and current_epoch (#686)

Summary:
Pull Request resolved: #686

A copy of D39902734 for joint LinUCB

Differential Revision: D39929408

fbshipit-source-id: 81983d9fc648fd3902a2d8b045ab368a240bac6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants