Fix reagent LRScheduler tests#697
Closed
janeyx99 wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Conversation
Summary: I recently exposed LRScheduler as a public endpoint as that is the right direction for users. This diff adds LRScheduler as a torch lr scheduler, which it is. Would fix test errors such as https://www.internalfb.com/intern/testinfra/diagnostics/281475249445597.562950030008200.1668085134/, which were introduced by my landing of D41109279. Created from CodeHub with https://fburl.com/edit-in-codehub Reviewed By: czxttkl Differential Revision: D41187073 fbshipit-source-id: 659b3fa6d3d97c5b94151f302b330e1702418cd8
|
This pull request was exported from Phabricator. Differential Revision: D41187073 |
Codecov ReportBase: 87.64% // Head: 87.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
=======================================
Coverage 87.64% 87.64%
=======================================
Files 365 365
Lines 23687 23687
Branches 44 44
=======================================
Hits 20760 20760
Misses 2901 2901
Partials 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #697 I recently exposed LRScheduler as a public endpoint as that is the right direction for users. This diff adds LRScheduler as a torch lr scheduler, which it is. Would fix test errors such as https://www.internalfb.com/intern/testinfra/diagnostics/281475249445597.562950030008200.1668085134/, which were introduced by my landing of D41109279. Created from CodeHub with https://fburl.com/edit-in-codehub Reviewed By: czxttkl Differential Revision: D41187073 fbshipit-source-id: 2637b6a80247c24620cf0ce8310e8181135637cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I recently exposed LRScheduler as a public endpoint as that is the right direction for users. This diff adds LRScheduler as a torch lr scheduler, which it is.
Would fix test errors such as https://www.internalfb.com/intern/testinfra/diagnostics/281475249445597.562950030008200.1668085134/, which were introduced by my landing of D41109279.
Created from CodeHub with https://fburl.com/edit-in-codehub
Reviewed By: czxttkl
Differential Revision: D41187073