Pass SummaryWriter to Offline Eval class to log metrics#705
Closed
alexnikulkov wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Pass SummaryWriter to Offline Eval class to log metrics#705alexnikulkov wants to merge 1 commit intofacebookresearch:mainfrom
alexnikulkov wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: Pass `SummaryWriter` to offline evaluators, so that they could log metrics to TensorBoard Differential Revision: D42251660 fbshipit-source-id: dcd1b951d3b57aac5b0321ed12fa34e8fd7e021a
|
This pull request was exported from Phabricator. Differential Revision: D42251660 |
Codecov ReportBase: 87.70% // Head: 87.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
+ Coverage 87.70% 87.72% +0.01%
==========================================
Files 373 373
Lines 24011 24039 +28
Branches 44 44
==========================================
+ Hits 21060 21088 +28
Misses 2925 2925
Partials 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This pull request has been merged in 2e72fdc. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #705 Pass `SummaryWriter` to offline evaluators, so that they could log metrics to TensorBoard Reviewed By: BerenLuthien Differential Revision: D42251660 fbshipit-source-id: 202cee318ad2ba47055b1ed945eebeeab88db226
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Pass
SummaryWriterto offline evaluators, so that they could log metrics to TensorBoardDifferential Revision: D42251660