add support for distributed Offline Eval#708
Closed
alexnikulkov wants to merge 1 commit intofacebookresearch:mainfrom
Closed
add support for distributed Offline Eval#708alexnikulkov wants to merge 1 commit intofacebookresearch:mainfrom
alexnikulkov wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D42407669 |
alexnikulkov
pushed a commit
to alexnikulkov/ReAgent
that referenced
this pull request
Jan 10, 2023
Summary: Pull Request resolved: facebookresearch#708 Adding support for distributed Offline Eval. This requires maintaining local buffers in each trainer instance and syncing them across all trainers periodically. The sync happens under one of 2 conditions: 1. When the "critical" weight of data has been consumed (will be set approximately equal to the size of 1-hr partition) 2. At the end of the training epoch (if data has been consumed since last sync) Also, updating the FREE pipeline to remove the restriction on number of nodes for Offline Eval runs Differential Revision: D42407669 fbshipit-source-id: b48ce0fee5f3b8155cb0189e51988986c169d08f
alexnikulkov
force-pushed
the
export-D42407669
branch
from
22cd3f5 to
3b48787
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42407669 |
Summary: Pull Request resolved: facebookresearch#708 Adding support for distributed Offline Eval. This requires maintaining local buffers in each trainer instance and syncing them across all trainers periodically. The sync happens under one of 2 conditions: 1. When the "critical" weight of data has been consumed (will be set approximately equal to the size of 1-hr partition) 2. At the end of the training epoch (if data has been consumed since last sync) Also, updating the FREE pipeline to remove the restriction on number of nodes for Offline Eval runs Differential Revision: D42407669 fbshipit-source-id: 634c94a594bedbd98d175d0c41371a717bab0306
alexnikulkov
force-pushed
the
export-D42407669
branch
from
3b48787 to
5aac164
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42407669 |
Codecov ReportBase: 87.72% // Head: 87.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
+ Coverage 87.72% 87.73% +0.01%
==========================================
Files 373 373
Lines 24042 24078 +36
Branches 44 44
==========================================
+ Hits 21091 21125 +34
- Misses 2925 2927 +2
Partials 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This pull request has been merged in 89519d7. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #708 Adding support for distributed Offline Eval. This requires maintaining local buffers in each trainer instance and syncing them across all trainers periodically. The sync happens under one of 2 conditions: 1. When the "critical" weight of data has been consumed (will be set approximately equal to the size of 1-hr partition) 2. At the end of the training epoch (if data has been consumed since last sync) Also, updating the FREE pipeline to remove the restriction on number of nodes for Offline Eval runs Differential Revision: D42407669 fbshipit-source-id: ce436b42b1bb01f3688c6f1f80c52a3d66a47b22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adding support for distributed Offline Eval. This requires maintaining local buffers in each trainer instance and syncing them across all trainers periodically. The sync happens under one of 2 conditions:
Also, updating the FREE pipeline to remove the restriction on number of nodes for Offline Eval runs
Differential Revision: D42407669