fix .grad=None issue when param is not sharded#1153
Merged
jiecaoyu merged 1 commit intongoyal_temp_fp32_main_gradfrom Dec 6, 2023
Merged
fix .grad=None issue when param is not sharded#1153jiecaoyu merged 1 commit intongoyal_temp_fp32_main_gradfrom
jiecaoyu merged 1 commit intongoyal_temp_fp32_main_gradfrom
Conversation
facebook-github-bot
added
the
CLA Signed
jiecaoyu
requested review from
jspark1105,
ngoyal2707,
vedanuj and
vivien-chu
vivien-chu
approved these changes
Dec 6, 2023
ngoyal2707
added a commit
that referenced
this pull request
Dec 7, 2023
…ot work for TE (#1151) * added temp changes for fp32 main grad, might not work for TE * post rebase * changes to keep reduced grad in fp32 (#1152) * fix .grad=None issue when param is not sharded (#1153) * fixed broken clipping (#1154) Co-authored-by: Naman Goyal <naman@fb.com> --------- Co-authored-by: Naman Goyal <naman@fb.com> Co-authored-by: Vedanuj Goswami <vedanuj@users.noreply.github.com> Co-authored-by: Jiecao Yu <jiecaoyu@umich.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix .grad=None issue when # DP group = 1 and param is not sharded.