Closed
Conversation
facebook-github-bot
added
the
CLA Signed
anj-s
reviewed
Feb 1, 2021
| skip_glob = ["build/*", "stubs/*"] | ||
| # Don't split "import" and "from". | ||
| force_sort_within_sections = true | ||
| known_third_party = ["benchmark_dataset", "dataclasses", "datasets", "golden_configs", "helpers", "models", "numpy", "pytest", "recommonmark", "setuptools", "torch", "torch_pg", "torchtext", "torchvision"] |
Contributor
Contributor
Author
There was a problem hiding this comment.
this is not enough, the pre-commit file also needs to be fixed, that's what I'm trying to say. This file is updated automatically
anj-s
approved these changes
Feb 1, 2021
blefaudeux
commented
Feb 1, 2021
| hooks: | ||
| - id: black | ||
| language_version: python3.6 | ||
| language_version: python3.7 |
Contributor
Author
There was a problem hiding this comment.
this is what changed the file below, because dataclasses were not part of 3.6 > added as a dependency -> means that import order needs to be changed (pure python and deps are not sorted the same way) -> broken lint when isort against 3.7
Contributor
Author
|
dupe with #348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
pre-commit was still set to the python 3.6 language model, which meant that dataclasses was added as a dependency. Fixing that
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃