Skip to content

Comments

Fix Gemfile.lock being detected as Ruby on Rails#148

Merged
facelessuser merged 1 commit intofacelessuser:masterfrom
oleg-vinted:fix/gemfile_lock
Jul 10, 2021
Merged

Fix Gemfile.lock being detected as Ruby on Rails#148
facelessuser merged 1 commit intofacelessuser:masterfrom
oleg-vinted:fix/gemfile_lock

Conversation

@oleg-vinted
Copy link

This fixes a minor annoyance with Gemfile files:

  • Gemfile.lock files are neither Ruby on Rails, nor Ruby files. Because there's no dedicated syntax for lock files, we're better off using plain text syntax.
  • Gemfile will now be set to plain Ruby by this configuration:
    "syntax": "Ruby/Ruby",
    "extensions": ["thor", "rake", "simplecov", "jbuilder", "rb", "podspec", "rabl"],
    "rules": [
    {"file_path": ".*/Gemfile$"},

@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: plugins Related to plugin modules. C: source Related to source code. labels Jun 29, 2021
@facelessuser
Copy link
Owner

Yeah, I don't recall where the change removed originated. It is possible things evolved and never got cleaned up. I don't use Ruby, so I'll defer to your opinion on this matter 🙂.

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Jun 29, 2021
@facelessuser facelessuser merged commit 47dd69c into facelessuser:master Jul 10, 2021
@oleg-vinted oleg-vinted deleted the fix/gemfile_lock branch July 12, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: plugins Related to plugin modules. C: source Related to source code. S: approved The pull request is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants