use CSV test files

[alexpvpmindustry]

Description

migrated from samples/quotes/History.xlsx to samples/quotes/*.csv
removed dependency of from openpyxl import load_workbook in tests/conftest.py

Fixes #188

Checklist

• My code follows the existing style, code structure, and naming taxonomy
• I have commented my code, particularly in hard-to-understand areas
• I have performed a self-review of my own code and included any verifying manual calculations
• I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
• My changes generate no new warnings and running code analysis does not produce any issues
• I have added or run the performance tests that depict optimal execution times
• I have made corresponding changes to the documentation

[DaveSkender]

First of all, thank you for contributing! I love what you're doing here, long overdue.

In addition to the specific comments, I have a general thought that duplicating these CSV files from the source seems a bit icky, but I also think referencing another repo is not a great practice. Can you think of a way to simply use the source CSV files rather than putting them here? The only reason I suggest it is that these tests mirror the originating DLL tests and I'd really only want to maintain these CSV files there, ideally, and not have to worry about syncing it here too.

[alexpvpmindustry]

First of all, thank you for contributing! I love what you're doing here, long overdue.

no problem 😊, just happen to stumble upon this dinosaur fossil 🤣

In addition to the specific comments, I have a general thought that duplicating these CSV files from the source seems a bit icky, but I also think referencing another repo is not a great practice. Can you think of a way to simply use the source CSV files rather than putting them here? The only reason I suggest it is that these tests mirror the originating DLL tests and I'd really only want to maintain these CSV files there, ideally, and not have to worry about syncing it here too.

i see what you meant. I'm not too sure if there is a method for this that works with pytest. but if the testing data doesn't change too often, I think copying the csv files over should probably be good enough.

[DaveSkender]

@LeeDongGeon1996 take a quick peek and merge when ready, LGTM.

[LeeDongGeon1996]

Thanks for your contribution !!
I've just left some comments. Please check when you're available :)

[DaveSkender]

One or more of these files aren’t importing correctly, not sure which ones. Unit tests are blowing up.

[alexpvpmindustry]

just to be sure, its in the import stage and not in the testing stage?
in the testing stage I get 7 failed unit tests, but I have no idea why they fail

this is the error log for one of the cases

[DaveSkender]

I think so. My hypothesis is based on all tests passing as of ab5cce9 previously.

[alexpvpmindustry]

ok i found the issue, there are several csv that don't follow the current parsing rules. ill fix them

[alexpvpmindustry]

ok fixed! lets wait for the tests to complete

[LeeDongGeon1996]

LGTM, thanks!

[DaveSkender]

Thanks for contributing @alexpvpmindustry, much appreciated. ❤️