Skip to content

Conversation

@LeeDongGeon1996
Copy link
Collaborator

@LeeDongGeon1996 LeeDongGeon1996 commented Mar 2, 2024

Description

  • Add explanatory error message for FormatException

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996
Copy link
Collaborator Author

@DaveSkender Could you check the error message is understandable?

@LeeDongGeon1996 LeeDongGeon1996 force-pushed the feature/add-error-message branch from 35f1976 to 779e399 Compare March 2, 2024 06:29
@LeeDongGeon1996
Copy link
Collaborator Author

Also, changed how we add additional error message.
See here: https://docs.python.org/3/tutorial/errors.html#enriching-exceptions-with-notes

@LeeDongGeon1996 LeeDongGeon1996 merged commit d502701 into facioquo:main Mar 2, 2024
@LeeDongGeon1996 LeeDongGeon1996 deleted the feature/add-error-message branch March 2, 2024 07:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants