Skip to content

Conversation

@LeeDongGeon1996
Copy link
Collaborator

@LeeDongGeon1996 LeeDongGeon1996 commented Mar 5, 2024

Description

  • Declare quote wrappers as class for better linting

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

Copy link
Member

@DaveSkender DaveSkender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I think it makes sense to only prepend the Cs when it's a native .NET type, for clarity. And, when it's a custom type only using an alias when there's a conflicting native Python type name.

@LeeDongGeon1996
Copy link
Collaborator Author

Thanks for your quick response. but I'll have a look tomorrow.

@LeeDongGeon1996 LeeDongGeon1996 merged commit 696b101 into facioquo:main Mar 7, 2024
@LeeDongGeon1996 LeeDongGeon1996 deleted the feat/change-wrapper-class-type branch March 7, 2024 13:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants