Skip to content

Conversation

@LeeDongGeon1996
Copy link
Collaborator

@LeeDongGeon1996 LeeDongGeon1996 commented Apr 6, 2024

Description

  • Add McGinley Dynamic

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996
Copy link
Collaborator Author

@DaveSkender maybe I don't have permission to publish test-coverage?

@DaveSkender
Copy link
Member

@DaveSkender maybe I don't have permission to publish test-coverage?

The new test reporter I was experimenting with is a bit flaky; I've just disabled it.

Copy link
Member

@DaveSkender DaveSkender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Were you planning to add docs page separately?

@LeeDongGeon1996
Copy link
Collaborator Author

LeeDongGeon1996 commented Apr 6, 2024

Were you planning to add docs page separately?

Yeah, since we merge directly into the main branch, I think it is better to add docs right before we deploy new features.

@LeeDongGeon1996 LeeDongGeon1996 merged commit 4448f0f into facioquo:main Apr 6, 2024
@LeeDongGeon1996 LeeDongGeon1996 deleted the feature/add-dynamic branch April 6, 2024 09:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants