Skip to content

Conversation

@LeeDongGeon1996
Copy link
Collaborator

@LeeDongGeon1996 LeeDongGeon1996 commented Apr 21, 2024

Description

  • Add condense() on all supported indicators
  • Bump up minimum version of typing_extensions to 4.4.0 for @override

Issue

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as draft April 21, 2024 13:26
@LeeDongGeon1996
Copy link
Collaborator Author

@DaveSkender I think Codacy config is reset. Please exclude /docs and /tests from its coverage target.

@LeeDongGeon1996 LeeDongGeon1996 changed the title feat: Add condense() on all supported indicators feat: Add condense() on all supported indicators Apr 28, 2024
@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as ready for review May 4, 2024 07:36
Copy link
Member

@DaveSkender DaveSkender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done. getting these extensions done well will make chaining (and then streaming) a bit easier when we eventually get to those parts.

indicators.get_alligator(quotes).condense()

do you think this will be possible soon too?

quotes.get_alligator().condense()

@LeeDongGeon1996
Copy link
Collaborator Author

That's the part I'm worried about recently. As I mentioned above, extension method is not supported, so we may need to find another approach to implement those features(chaining, streaming)

@LeeDongGeon1996 LeeDongGeon1996 merged commit 8a550f7 into facioquo:main May 4, 2024
@LeeDongGeon1996 LeeDongGeon1996 deleted the feat/add-condense branch May 4, 2024 08:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants