Skip to content

feat(proxy): add setting to be able to use proxies#26

Merged
Michael Matzka (mima0815) merged 8 commits into
mainfrom
feat/proxy
Mar 31, 2023
Merged

feat(proxy): add setting to be able to use proxies#26
Michael Matzka (mima0815) merged 8 commits into
mainfrom
feat/proxy

Conversation

@mima0815
Copy link
Copy Markdown
Contributor

@mima0815 Michael Matzka (mima0815) commented Jan 27, 2023

Description

Add the ability to specify proxies, proxy_headers and to pass custom CA files to be able to verify self issued certificates.

Checklist

Ensure the following things have been met before requesting a review:

  • Follows all project developer guide and coding standards.
  • Tests have been written for the change, when applicable.
  • Confidential information (credentials, auth tokens, etc...) is not included.

@mima0815 Michael Matzka (mima0815) force-pushed the feat/proxy branch 5 times, most recently from dcb1c37 to cd04af3 Compare January 30, 2023 17:39
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How

Comment thread src/fds/sdk/utils/authentication/confidential.py Outdated
Comment thread src/fds/sdk/utils/authentication/confidential.py Outdated
@mima0815 Michael Matzka (mima0815) marked this pull request as ready for review March 9, 2023 11:28
@mima0815 Michael Matzka (mima0815) requested a review from a team as a code owner March 9, 2023 11:28
Copy link
Copy Markdown
Contributor

@granitdula Granit Dula (granitdula) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a typo in the README

Comment thread README.md Outdated
@mima0815 Michael Matzka (mima0815) deleted the feat/proxy branch March 31, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants