feat(request): request retry config option#77
Merged
Conversation
Michael Matzka (mima0815)
force-pushed
the
feat/requestretry
branch
10 times, most recently
from
cf2f2be to
2103422
Compare
Michael Matzka (mima0815)
force-pushed
the
feat/requestretry
branch
from
2103422 to
5b2aa0d
Compare
Michael Matzka (mima0815)
changed the title
Michael Matzka (mima0815)
changed the title
Michael Matzka (mima0815)
changed the title
Michael Matzka (mima0815)
changed the title
gdulafactset
previously approved these changes
Apr 4, 2024
Erik Schmidt (eschmidtfds)
previously approved these changes
Apr 4, 2024
Contributor
Erik Schmidt (eschmidtfds)
left a comment
Erik Schmidt (eschmidtfds)
left a comment
There was a problem hiding this comment.
Please double check if that backoff_factor makes sense. Otherwise LGTM.
Michael Matzka (mima0815)
dismissed stale reviews from Erik Schmidt (eschmidtfds) and gdulafactset
via
81327b9
Contributor
Author
Checked to which values other projects set the factor: they use higher values. changed our value to 1. |
gdulafactset
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows to configure request retries in case a request returned an error response.
Updated retry defaults.
Checklist
Ensure the following things have been met before requesting a review: