making Singelton pattern#256
Closed
mikelfried wants to merge 1 commit intofaif:masterfrom
mikelfried:master
Closed
making Singelton pattern#256mikelfried wants to merge 1 commit intofaif:masterfrom mikelfried:master
mikelfried wants to merge 1 commit intofaif:masterfrom
mikelfried:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
- Coverage 97.75% 97.74% -0.02%
==========================================
Files 61 62 +1
Lines 2276 2301 +25
==========================================
+ Hits 2225 2249 +24
- Misses 51 52 +1
Continue to review full report at Codecov.
|
Owner
Contributor
|
hi @faif . maybe we could add this pattern as "no go" into readme, with corresponding remark? |
Owner
|
Added the wontfix label, that should help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the Singelton Pattern