Conversation
|
The changes look good. Do you know why the linter fails? |
|
@faif Mainly because several linters founded errors in the code-base. Unfortunately the setup of the GitHub Actions workflow with an embedded script with a wide variety of linters is not really effective, because you are not able to see which linter is failing and the reason behind it. From a user perspective, it is not user friendly as well, because lint.sh just installs the packages system-wide instead in a virtualenv. In my humble opinion. It This will improve the efficiency greatly. |
Upgraded flake8 to 7.1
…error, it will continue.
|
I have added a adjusted lint_python workflow where all the linters are executed but per step. You now see what and why a linter fails. For now, I added the option to continue on error, so that there is room to fix all the problems. |
|
I also added a workflow that lints per PR and Pull and not everything (which is a lot) You can decide what you want with it. |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| tool: [flake8, format, mypy, pytest, pyupgrade, tox] |
There was a problem hiding this comment.
I can't believe I never thought to try this approach before. love this.
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", |
There was a problem hiding this comment.
should 3.13 be listed in this if we are only testing against 3.12
There was a problem hiding this comment.
You are correct. I'll change this.
python-patterns/blob/master/setup.cfg
python-patterns/blob/master/setup.py
python-patterns/blob/master/.travis.yml
python-patterns/blob/master/lint.sh
python-patterns/blob/master/tox.ini
The errors from the workflow are now caused by genuine formatting bugs and missing types