refactoring avatar settings #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
afragen
approved these changes
Jun 23, 2025
Contributor
afragen
left a comment
afragen
left a comment
There was a problem hiding this comment.
Seems to work great. Setting now under Discussions where Avatars are chosen.
joedolson
requested changes
Jun 23, 2025
Member
joedolson
left a comment
joedolson
left a comment
There was a problem hiding this comment.
We should do something to handle previous settings.
johnbillion
reviewed
Jun 23, 2025
Signed-off-by: Norcross <andrew.norcross@gmail.com>
Signed-off-by: Norcross <andrew.norcross@gmail.com>
Signed-off-by: Norcross <andrew.norcross@gmail.com>
Signed-off-by: Norcross <andrew.norcross@gmail.com>
Signed-off-by: Norcross <andrew.norcross@gmail.com>
norcross
force-pushed
the
feature/multisite-avatar-settings
branch
from
40bad17 to
70ce59a
Compare
Ipstenu
approved these changes
Jul 17, 2025
joedolson
approved these changes
Jul 17, 2025
Signed-off-by: Norcross <andrew.norcross@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR updates the current settings implementation for the avatar source. this breaks up the settings and moves to two separate functions.
load_single_site_avatar_settingsis for single sites, and fully utilizes the Settings APIwpmu_optionsandupdate_wpmu_optionsto handle the multisitethe setting key is currently set as a serialized array, and this converts it to a single key. this also removes the CSS file that was added for the stand-alone settings page.
this addresses #70