test(rds): force postgres image rebuild for aws_s3 e2e#807
Merged
vieiralucas merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
The published `fakecloud-postgres:16-0.13.1` image lacks the aws_s3 extension files (they ship with the next release), so the runtime's pull-first path returned an image without the new extension and `CREATE EXTENSION aws_s3` failed in CI. Set `FAKECLOUD_REBUILD_POSTGRES_IMAGE=1` for this test so it always builds locally from the embedded assets in this commit. Goes away naturally once v0.13.2 publishes the image with aws_s3 baked in.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #806 merged the aws_s3 extension but the e2e test fails on CI because the runtime's pull-first path returns
fakecloud-postgres:16-0.13.1(last published image) which lacks the new aws_s3 extension files.Set
FAKECLOUD_REBUILD_POSTGRES_IMAGE=1for the new test so it always builds locally from the embedded assets at HEAD. Goes away naturally once v0.13.2 publishes the image with aws_s3 baked in.Test plan
cargo check -p fakecloud-e2e --testscargo test -p fakecloud-e2e --test rds_aws_s3(Docker required — runs in CI)Summary by cubic
Force a local rebuild of the Postgres image in the
rds_aws_s3e2e test so theaws_s3extension is available and the test passes in CI. SetsFAKECLOUD_REBUILD_POSTGRES_IMAGE=1to bypass the pull-first path that currently returnsfakecloud-postgres:16-0.13.1; this can be removed once v0.13.2 publishes the updated image.Written for commit b1a4f1a. Summary will update on new commits. Review in cubic