fix(rds): unblock fakecloud-mysql/mariadb image builds#811
Merged
vieiralucas merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
PR #810 broke `docker-rds-images.yml` for the new mysql/mariadb matrix entries. Three issues, all caught on the first matrix run after merge: - `fakecloud_udf.c` used bare `bool` without including `<stdbool.h>`. The mariadb (Debian) base image's gcc is strict about that. Add the include. - `mysql:8.0`'s base image is Oracle Linux 8 with `microdnf`. The previous `microdnf install ... || apt-get install ...` short-form failed because microdnf returned 127 (package not found in the default minimal repo set), and apt-get isn't installed on OL8. Switch to a real `if/elif` shell branch; for microdnf, opt into the `ol8_codeready_builder` repo which carries libcurl-devel. - mysql 5.7's image base no longer ships either microdnf or apt (and 5.7 community support ended October 2023). Drop it from the matrix and from the runtime engine-version map; any caller asking for `5.7*` now gets 8.0.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #810 left the new MySQL/MariaDB image-build matrix red. Fix three issues caught on the first post-merge run:
fakecloud_udf.cused bareboolwithout<stdbool.h>. Add the include.mysql:8.0base is Oracle Linux 8 withmicrodnf(not apt). Switch the package install to a realif/elifshell branch and opt intool8_codeready_builderfor libcurl-devel.mysql 5.7from the matrix (community support ended Oct 2023; image base no longer ships our build deps). Runtime now resolves any5.7*engine version to 8.0.Test plan
cargo clippy --workspace --all-targets -- -D warningscargo fmt --all -- --checkdocker-rds-images.ymlPR run all greenSummary by cubic
Unblocks MySQL/MariaDB image builds. Fixes UDF headers, makes the MySQL Dockerfile OS-aware, and removes unsupported MySQL 5.7 (runtime now resolves 5.7.* to 8.0).
<stdbool.h>to MySQL and MariaDB UDF sources.microdnfvsapt-get, enableol8_codeready_builder, and installpkgconf-pkg-config/pkg-config.5.7.*engine request to8.0at runtime.Written for commit 9842d2b. Summary will update on new commits. Review in cubic