fix(sdk-java): use dbInstanceStatus() in e2e poll#815
Merged
vieiralucas merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
`*AsString()` accessors only exist for fields that have an enum type in the Smithy model. AWS SDK v2's `DBInstance.dbInstanceStatus` is a plain `String`, so the accessor is the bare `dbInstanceStatus()`. PR #809's poll loop used the enum-style name and Java compilation broke.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #809 added a
DescribeDBInstancespoll loop in the Java SDK e2e and calleddbInstanceStatusAsString(), but AWS SDK v2 only generates*AsString()accessors for enum-typed Smithy fields.DBInstance.dbInstanceStatusis a plainString, so the bare accessor is correct and the enum-style name fails compilation.Test plan
./gradlew testinsdks/javacompiles and runs.build-and-testjob passes.Summary by cubic
Fixes the Java SDK e2e RDS poll to use dbInstanceStatus() (a String) instead of dbInstanceStatusAsString(). This restores compilation and correctly checks for "available".
Written for commit 67ef31d. Summary will update on new commits. Review in cubic