feat: cargo workspace and protobuf api definitions (story 1.1)#1
Merged
vieiralucas merged 2 commits intomainfrom Feb 11, 2026
Merged
Conversation
establish the project foundation with a four-crate cargo workspace (fila-proto, fila-core, fila-server, fila-cli) and define the complete protobuf api surface: messages.proto (message envelope), service.proto (hot-path rpcs), and admin.proto (operator rpcs). fila-proto generates rust types and grpc service code via tonic-prost-build 0.14.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
vieiralucas
commented
Feb 11, 2026
vieiralucas
deleted the
feat/1-1-cargo-workspace-protobuf-definitions
branch
vieiralucas
added a commit
that referenced
this pull request
Mar 18, 2026
- apply_to_broker_storage now returns Result and propagates StorageError instead of silently swallowing storage failures (cubic #1) - add DeleteLeaseExpiry mutation in ack/nack replication paths to clean up orphaned lease expiry entries (cubic #3) - fix no-op leased_msg_keys.retain in recovery — now properly clears entries for the recovering queue before rebuild (cubic #4) - warn when create_group is called without broker_storage set (cubic #5) - check send_command result in watch_leader_changes — only update leading state on success so next poll retries on failure (cubic #6, #7) - trigger RecoverQueue on first-sight leader state to catch messages replicated between startup and first poll (cubic #8) - replace catch-all _ => {} with explicit variant listing in apply_to_broker_storage for compiler-enforced exhaustiveness
vieiralucas
added a commit
that referenced
this pull request
Mar 18, 2026
- apply_to_broker_storage now returns Result and propagates StorageError instead of silently swallowing storage failures (cubic #1) - add DeleteLeaseExpiry mutation in ack/nack replication paths to clean up orphaned lease expiry entries (cubic #3) - fix no-op leased_msg_keys.retain in recovery — now properly clears entries for the recovering queue before rebuild (cubic #4) - warn when create_group is called without broker_storage set (cubic #5) - check send_command result in watch_leader_changes — only update leading state on success so next poll retries on failure (cubic #6, #7) - trigger RecoverQueue on first-sight leader state to catch messages replicated between startup and first poll (cubic #8) - replace catch-all _ => {} with explicit variant listing in apply_to_broker_storage for compiler-enforced exhaustiveness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fila-proto,fila-core,fila-server,fila-cli.protofiles:messages.proto— Message envelope with metadata and timestampsservice.proto—FilaServicewith Enqueue, Lease (server-streaming), Ack, Nack RPCsadmin.proto—FilaAdminwith CreateQueue, DeleteQueue, SetConfig, GetConfig, GetStats, Redrive RPCsfila-protocrate withtonic-prost-build0.14 codegen pipeline andrerun-if-changeddirectivescargo build,cargo clippy -D warnings, andcargo fmt --checkAcceptance Criteria (Story 1.1)
messages.protodefines Message envelopeservice.protodefines FilaService with 4 RPCsadmin.protodefines FilaAdmin with 6 RPCsfila-protobuild.rs generates Rust types and gRPC codefila-proto/src/lib.rsre-exports all generated typesTest plan
cargo build— all crates compilecargo clippy -- -D warnings— zero warningscargo fmt --check— properly formatted🤖 Generated with Claude Code
Summary by cubic
Established a four-crate Cargo workspace and the full gRPC/Protobuf API for Fila. Minor cleanup since last summary: removed redundant comments in workspace dependencies. Addresses Story 1.1 with tonic-prost-build 0.14; all crates compile clean.
New Features
Migration
Written for commit 49ccf67. Summary will update on new commits.