Bump 'rdoc' dependency, handle 'erb' version constraint with Ruby 3.1 and improve CI bundle cache #3185
+18
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefannibrasil
changed the title
stefannibrasil
changed the title
To speed our CI a bit, let's cache the dependencies. I am using the recommended cache strategy for Ruby: https://github.com/actions/cache/blob/main/examples.md#ruby---bundler Additionally, to use the `--without` configuration, we need to explicitely set the configuration keys through the environment: https://bundler.io/man/bundle-config.1.html#CONFIGURATION-KEYS
After changing CI to use ruby/setup-ruby cache, CI fails for Ruby 3.1 because 'erbv 6.0' is not compatible with that ruby version. Although RUby 3.1 is EOL, we will support it until Ruby 3.2 becomes EOL.
stefannibrasil
force-pushed
the
sb-rdoc-bump-version-ci-errors
branch
from
2cbf8e8 to
adb6cc5
Compare
stefannibrasil
commented
Jan 14, 2026
|
|
||
| PLATFORMS | ||
| arm64-darwin-22 | ||
| arm64-darwin |
Contributor
Author
There was a problem hiding this comment.
With the specific versions that is being removed, I was getting a diff every time I ran bundle install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because bumping
rdocwithout handling theerbversion constraint for Ruby 3.1 breaks CI. See #3178When bumping 'rdoc''s version, we need to handle 'erb' manually while Ruby 3.1 is still supported.
Closes #3182
Additional information
Since I was working on CI, I took the opportunity to cache the dependencies automatically using ruby/setup-ruby recommendation.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]