Skip to content

Conversation

@samcday
Copy link

@samcday samcday commented Mar 23, 2024

I followed this issue for guidance: PCRE2Project/pcre2#51

pcre2 approach seems a bit slower, likely because it's allocating those match_data structs for every check. I tried to allocate it once during init but it seemed to segfault 😅

@samcday
Copy link
Author

samcday commented Mar 23, 2024

I based this patch off v21 since master wasn't building cleanly for me. The fix in #61 has been unmerged for a while so I wasn't sure what the state of this project is.

@samcday samcday closed this by deleting the head repository Apr 15, 2024
@falconindy
Copy link
Owner

falconindy commented Aug 7, 2024

Just FYI, I think I'd sooner move to RE2 than "upgrade" to PCRE2. I've looked at this before and it's a tire fire.

@loqs
Copy link

loqs commented Mar 10, 2025

Just FYI, I think I'd sooner move to RE2 than "upgrade" to PCRE2.

@falconindy Is loqs@1964f49 something similar to what you hand in mind for the move to RE2?

@falconindy
Copy link
Owner

falconindy commented Mar 11, 2025

Just FYI, I think I'd sooner move to RE2 than "upgrade" to PCRE2.

@falconindy Is loqs@1964f49 something similar to what you hand in mind for the move to RE2?

@loqs Looks good! Gave you a code review in the worst way possible. But well, performance of RE2 seems to be junk compared to PCRE despite rsc blog posts suggesting otherwise.

@loqs
Copy link

loqs commented Mar 11, 2025

But well, performance of RE2 seems to be junk compared to PCRE despite rsc blog posts suggesting otherwise.

If PCRE2 and RE2 are both out there is std:basic_regex.

@loqs loqs mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants