Skip to content

add install suggestion for zsh command-not-found #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mk990 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add install suggestion for zsh command-not-found #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions extra/command-not-found.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ command_not_found_handler() {
if [[ -n "$pkgs" ]]; then
printf '%s may be found in the following packages:\n' "$cmd"
printf ' %s\n' $pkgs[@]
if [[ -n $PKGFILE_PROMPT_INSTALL_MISSING ]]; then
Copy link
Owner

@falconindy falconindy Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should elide the check here that's done in bash -- invoking this behavior only when pkgfile returns a single result. At best, you offer to install a randomly selected package that might not be what the user wants.

pkg=`echo $pkgs | cut -f1 -d " "`
echo -n "Install $pkg? [Y/n]"
read -r response
[[ -z $response || $response = [Yy] ]] || return 0
printf '\n'
sudo pacman -S --noconfirm -- "$pkg"
return
fi
else
printf 'zsh: command not found: %s\n' "$cmd"
fi 1>&2
Expand Down