Skip to content

new: images#60

Merged
poiana merged 1 commit intomainfrom
new/images
Jul 27, 2023
Merged

new: images#60
poiana merged 1 commit intomainfrom
new/images

Conversation

@therealbobo
Copy link
Collaborator

@therealbobo therealbobo commented Jul 24, 2023 •
edited
Loading

Introducing new images to test the libraries with. This includes all the necessary files (Dockerfiles and additional files) for image creation.

@FedeDP
Copy link
Collaborator

FedeDP commented Jul 24, 2023

Can you add a README under images/generated-images with some isntructions, and under images/static-images stating that these are the dockerfiles for the images used by the tool?
Thanks, and btw huge work!!

@therealbobo therealbobo force-pushed the new/images branch 4 times, most recently from ae41b25 to 3b0d57a Compare July 26, 2023 10:47
@FedeDP
Copy link
Collaborator

FedeDP commented Jul 26, 2023

/close

@poiana poiana closed this Jul 26, 2023
@poiana
Copy link

poiana commented Jul 26, 2023

@FedeDP: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Collaborator

FedeDP commented Jul 26, 2023

/reopen

@poiana poiana reopened this Jul 26, 2023
@poiana
Copy link

poiana commented Jul 26, 2023

@FedeDP: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@therealbobo therealbobo force-pushed the new/images branch 2 times, most recently from 23a0e0e to beb0222 Compare July 26, 2023 10:59
@therealbobo therealbobo force-pushed the new/images branch 4 times, most recently from 8ca08b3 to 42e8062 Compare July 26, 2023 15:26
@poiana poiana added size/S and removed size/XXL labels Jul 26, 2023
@poiana poiana added size/XXL and removed size/S labels Jul 26, 2023
@therealbobo therealbobo force-pushed the new/images branch 3 times, most recently from 42dd590 to 284e4c8 Compare July 26, 2023 18:52
FedeDP
FedeDP reviewed Jul 27, 2023
View reviewed changes
@therealbobo
feat: added test images
ccc0a8c 
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
FedeDP
FedeDP approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jul 27, 2023
@poiana
Copy link

poiana commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jul 27, 2023

LGTM label has been added.

DetailsGit tree hash: 286c433fa35fcfe79e9db275ff726e8dd6263247

@poiana poiana merged commit cec0131 into main Jul 27, 2023
@poiana poiana deleted the new/images branch July 27, 2023 09:01
@therealbobo therealbobo mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FedeDP FedeDP FedeDP approved these changes

Assignees

@FedeDP FedeDP

Labels

approved dco-signoff: yes lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@therealbobo @FedeDP @poiana