fix: don't throw exception on iteration breakout#42
Merged
poiana merged 1 commit intofalcosecurity:masterfrom Dec 20, 2024
Merged
fix: don't throw exception on iteration breakout#42poiana merged 1 commit intofalcosecurity:masterfrom
poiana merged 1 commit intofalcosecurity:masterfrom
Conversation
Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, mrgian The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 783a88b0c6aac002660943521d2fd8ddb4b7e0ff |
Contributor
|
/milestone 0.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
What this PR does / why we need it:
Avoid throwing an exception when
iterate_entriesreturnsfalse.The
falsereturn statement is used to breakout from the iteration and doesn't necessarily means an error has occurred.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: