Open
Conversation
Collaborator
Author
|
Looks like there is an issue with .NET Standard 2.0 projects with the Pushing this off for now. If any clients want .NET Standard/Core 2.0 support they will have to adapt the project as we did in 1b33764 |
|
Why not scrap the Newtonsoft.Json entirely and go with the better-performing first-party |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would allow .NETCORE users to also use our project. Only downside is we now pull in a nuget pkg (Newtonsoft.Json).
@ScottGimpel since you did the nuget package stuff we can leave this until you get some time to look at it. I'm not sure what hte process to update the nuget pkg would be since we are changing our target framework and supported frameworks. You'll prob want to try it out on the dotnetstandard2 branch to make sure the project works and all haha