This repository was archived by the owner on Oct 1, 2020. It is now read-only.
Support list items of variable height#56
Closed
ssafejava wants to merge 1 commit intofarhadi:masterfrom
Closed
Conversation
…n hovering over larger items.
Collaborator
|
This project has been discontinued by its author and the new mantained version is here. Since the projects have diverged a while ago I can't migrate issues and pull requests. Please try the new version and if the issue or pull request still makes sense, please resubmit it. Sorry for the inconvenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a list is composed of items of varying height, when dragging a smaller item over a large item, one will see flickering as the placeholder is placed before the item, then after the item, and back again, infinitely.
jQuery-UI uses something approximating a dead zone, where the swap will only occur over an area equal to the item being dragged. For example, if dragging a 20px tall item over a 40px tall item, no swap will occur over the first 20px while dragging from above, or over the last 20px while dragging from below.
This small patch creates a deadzone inside larger items, resolving the flicking issue.