fix: content layout on spider monkey browser engine#137
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@farming-labs/astro
@farming-labs/astro-theme
@farming-labs/docs
@farming-labs/theme
@farming-labs/next
@farming-labs/nuxt
@farming-labs/nuxt-theme
@farming-labs/svelte
@farming-labs/svelte-theme
@farming-labs/tanstack-start
commit: |
Greptile SummaryThis PR removes a Confidence Score: 5/5Safe to merge — the change is a clean removal of a redundant wrapper div with no functional regressions. All remaining findings are P2 or lower. The No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["createDocsLayout / TanstackDocsLayout"] --> B["DocsLayout\n(fumadocs-ui/layouts/docs)\nroot: id='nd-docs-layout'"]
B --> C["ColorStyle / TypographyStyle / LayoutStyle"]
B --> D["DocsCommandSearch (Suspense)"]
B --> E["DocsAIFeatures (Suspense, if enabled)"]
B --> F["DocsPageClient (Suspense)"]
F --> G["children"]
style A fill:#f0f4ff,stroke:#4f6ef7
style B fill:#d1fae5,stroke:#059669
classDef removed fill:#fee2e2,stroke:#ef4444
OLD["Removed: div#nd-docs-layout style=display:contents caused SpiderMonkey layout bug"]:::removed
Reviews (1): Last reviewed commit: "chore: format" | Re-trigger Greptile |
Summary by cubic
Removed the extra display: contents wrapper around the docs layout root to fix layout issues on SpiderMonkey/Firefox. Rendering is now stable across browsers with no API changes.
createDocsLayoutandTanstackDocsLayout, removed the outer<div id="nd-docs-layout" style="display: contents">and renderDocsLayoutas the root.Written for commit 74f9c47. Summary will update on new commits. Review in cubic