✨ Add overload for exec method to support insert, update, delete statements#1342
Merged
tiangolo merged 6 commits intofastapi:mainfrom Sep 17, 2025
Merged
✨ Add overload for exec method to support insert, update, delete statements#1342tiangolo merged 6 commits intofastapi:mainfrom
exec method to support insert, update, delete statements#1342tiangolo merged 6 commits intofastapi:mainfrom
Conversation
|
On #1349 you asked for feedbacks on your PR: I tested it and it fixed my typing errors! Previously I had this mypy output: After applying your patch, the type error is solved. |
|
Hope this gets merged soon! Good job @seriaati |
exec method to support insert, update, delete statements
YuriiMotov
approved these changes
Aug 15, 2025
Member
YuriiMotov
left a comment
There was a problem hiding this comment.
LGTM!
This fixes the typing issue when we use exec method with insert, update or delete statements. Currently it works, but type checkers raise warnings. This PR fixes this.
@seriaati, thanks for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address #909