#75 add sessionmaker#81
Closed
charlie-pecora wants to merge 1 commit intofastapi:mainfrom
charlie-pecora:add_sessionmaker_75
Closed
#75 add sessionmaker#81charlie-pecora wants to merge 1 commit intofastapi:mainfrom charlie-pecora:add_sessionmaker_75
charlie-pecora wants to merge 1 commit intofastapi:mainfrom
charlie-pecora:add_sessionmaker_75
Conversation
…l.sessionmaker by default
|
why closed? we need sessionmaker... |
|
For anyone in the future who comes here and also wants sqlmodel to have a sessionmaker implementation. Wondering why this PR was not merged. Be very thankful it wasn't! The author simply really really wanted to wrap sessionmaker, but then didn't address the underlying issue. Now you have a wrapped sessionmaker that still won't work. Look back at #75 for a temporary workaround and how to actually resolve the underlying issue. Then can come back and will realize [async_]sessionmaker are perfect as-is. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#75 Implemented a basic sessionmaker class that returns an instance of the sqlmodel.Session by default (can be overridden by passing the
class_keyword argument to the sessionmaker)A basic test showing the functionality:
I am not sure where it makes sense to test and show that
sessionmakeris available in the docs.