✨Properly support inheritance of Relationship attributes#886
Open
earshinov wants to merge 5 commits intofastapi:mainfrom
Open
✨Properly support inheritance of Relationship attributes#886earshinov wants to merge 5 commits intofastapi:mainfrom
earshinov wants to merge 5 commits intofastapi:mainfrom
Conversation
6d05a4b to
8f30325
Compare
8 tasks
2200fc5 to
f95b739
Compare
earshinov
commented
Apr 12, 2024
f95b739 to
766d08a
Compare
Csaba1205
approved these changes
Apr 23, 2024
7fd0c5f to
46c8d62
Compare
Contributor
|
This pull request has a merge conflict that needs to be resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the test I added:
Given how the test model is defined and without the proposed fix, the test fails with:
That is, a
Relationshipdefined in the base model is not recognized as a relationship in the child.