-
Notifications
You must be signed in to change notification settings - Fork 20
upgrade bazel to 8 #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e16a44c
upgrade modules
apesternikov 4360127
no vendor
apesternikov a0f2cab
update tests
apesternikov 8fa198a
update e2e
apesternikov 193e710
go mod tidy
apesternikov 87497b8
bump go
apesternikov c592b78
update k8s client
apesternikov f8b61b8
canonical bcr name for rules_go and gazelle
apesternikov 50682ff
upgrade protobuf
apesternikov 3bbe2be
fix e2e
apesternikov f92fd24
cleanup
apesternikov 6ecb22b
upgrade k8s client
apesternikov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,13 @@ | ||
| common --enable_bzlmod | ||
| common --enable_bzlmod --noincompatible_sandbox_hermetic_tmp | ||
| build --nolegacy_external_runfiles | ||
| build --remote_download_all | ||
| build --verbose_failures | ||
| build --@io_bazel_rules_go//go/config:pure | ||
| build --@rules_go//go/config:pure | ||
| test --test_output=errors | ||
|
|
||
| common --incompatible_enable_proto_toolchain_resolution | ||
| # Ensure that we don't accidentally build protobuf or gRPC | ||
| common --per_file_copt=external/.*protobuf.*@--PROTOBUF_WAS_NOT_SUPPOSED_TO_BE_BUILT | ||
| common --host_per_file_copt=external/.*protobuf.*@--PROTOBUF_WAS_NOT_SUPPOSED_TO_BE_BUILT | ||
| common --per_file_copt=external/.*grpc.*@--GRPC_WAS_NOT_SUPPOSED_TO_BE_BUILT | ||
| common --host_per_file_copt=external/.*grpc.*@--GRPC_WAS_NOT_SUPPOSED_TO_BE_BUILT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 7.1.2 | ||
| 8.2.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script embeds user-facing documentation about Bazel usage and version support directly within operational code. This mixing of concerns can lead to maintenance challenges as changes in functionality might require updates to embedded documentation, which could be overlooked.
Recommendation: Consider separating operational code from user-facing documentation. Documentation could be moved to a separate markdown file or a dedicated documentation section within the repository. This separation would enhance clarity and maintainability.