Addition of missing date attribute for velocity profiles#4
Open
tbartholomaus wants to merge 1 commit intofastice:masterfrom
Open
Addition of missing date attribute for velocity profiles#4tbartholomaus wants to merge 1 commit intofastice:masterfrom
tbartholomaus wants to merge 1 commit intofastice:masterfrom
Conversation
Call to `myVelSeries.plotProfile` in the example workingWithGrIMPVelocity.ipynb was missing use of a `date` attribute, which caused example plot to repeatedly plot only one date. Small correction to that here, as well as a tweak to the language describing the plot.
Owner
|
I think this was fixed last week. Try downloading latest commit. IanIan JoughinPolar Science CenterApplied Physics LabU Washington206-221-3177On Dec 3, 2022, at 1:58 PM, Timothy Bartholomaus ***@***.***> wrote:Call to myVelSeries.plotProfile in the example workingWithGrIMPVelocity.ipynb was missing use of a date attribute, which caused example plot to repeatedly plot only one date. Small correction to that here, as well as a tweak to the language describing the plot.
You can view, comment on, or merge this pull request online at:
#4
Commit Summary
08e9f77 Addition of missing dates for profiles
File Changes (1 file)
M
workingWithGrIMPVelocity.ipynb
(4)
Patch Links:
https://github.com/fastice/GrIMPNotebooks/pull/4.patch
https://github.com/fastice/GrIMPNotebooks/pull/4.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Owner
Author
|
I'm impressed you're trying to resolve pull requests on your phone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call to
myVelSeries.plotProfilein the example workingWithGrIMPVelocity.ipynb was missing use of adateattribute, which caused example plot to repeatedly plot only one date. Small correction to that here, as well as a tweak to the language describing the plot.