Open
Conversation
This was necessary to make the solver converge only on the first call after changes to icepack to regularize Glen's flow law around zero strain rate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change increases the max number of iterations for the diagnostic solver. I added regularization to Glen's flow law around zero strain rate to icepack, but with the default of 50 max iterations this makes the inverse solver fail. Increasing to 100 max iterations seems to make the code work again. On the first call to diagnostic solve, the initial guess is quite far from the final result, so the need to increase the number of iterations shouldn't be too concerning.