Integrate cookie, use improved cookie parsing method#152
Merged
Eomm merged 4 commits intofastify:masterfrom Nov 23, 2021
Merged
Integrate cookie, use improved cookie parsing method#152Eomm merged 4 commits intofastify:masterfrom
Eomm merged 4 commits intofastify:masterfrom
Conversation
integrate cookie package integrate cookie tests rename cookie.test.js to plugin.test.js
Eomm
reviewed
Nov 23, 2021
zekth
approved these changes
Nov 23, 2021
Eomm
approved these changes
Nov 23, 2021
kurtextrem
added a commit
to kurtextrem/fastify-cookie
that referenced
this pull request
Jul 14, 2022
Previously, in PR fastify#152 we removed the `cookie` dep., since the repo was stale. The cookie module seems to be active again, and now actually the current implementation was outdated and lacking a performance fix from ~4 months ago.
4 tasks
mcollina
pushed a commit
that referenced
this pull request
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we discussed in #151 here is a PR for the change.
How should we proceed with the documentation? Should I copy paste it into the Readme.md or is the reference to the original repo OK?
Are the credits just in the cookie.js OK? Or is there a guideline on how to credit?
Checklist
npm run testandnpm run benchmarkand the Code of conduct