Test: Fastify #5555 - move to node test runner#404
Merged
Conversation
dancastillo
reviewed
Feb 8, 2025
Member
dancastillo
left a comment
dancastillo
left a comment
There was a problem hiding this comment.
can you update t.assert.equal to t.assert.strictEqual and t.assert.notEqual to t.assert.notStrictEqual
simone-sanfratello
approved these changes
Feb 12, 2025
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Moving the tests from
tapto the node test runner, based on what requested in the following issueFastify #5555
npm run testandnpm run benchmarkand the Code of conduct