Skip to content

chore: update deps#436

Merged
mcollina merged 4 commits into
fastify:mainfrom
simone-sanfratello:chore/maintenance
Nov 23, 2025
Merged

chore: update deps#436
mcollina merged 4 commits into
fastify:mainfrom
simone-sanfratello:chore/maintenance

Conversation

@simone-sanfratello
Copy link
Copy Markdown
Contributor

@simone-sanfratello simone-sanfratello commented Nov 20, 2025

  • update deps
  • removed got in tests in favor of native fetch
  • removed @jsumners/line-reporter as in case of failures it's not possible to see output

Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not directly use fetch? I would prefer removing that helper fn

@kibertoad
Copy link
Copy Markdown
Member

@Uzlopak wouldn't that require more boilerplate in every test?

@Uzlopak
Copy link
Copy Markdown
Contributor

Uzlopak commented Nov 20, 2025

@kibertoad Actually not.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job

@mcollina mcollina merged commit 031f4d4 into fastify:main Nov 23, 2025
14 checks passed
@simone-sanfratello simone-sanfratello deleted the chore/maintenance branch November 23, 2025 19:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants