improve codebase and performance#41
Merged
mcollina merged 8 commits intofastify:masterfrom Jul 7, 2022
Merged
Conversation
Uzlopak
commented
Jul 6, 2022
Contributor
Author
|
I was actually investigating if i could improve the original package of dougwilson. Then i saw you already created a fork. I hope you like it... |
Contributor
Author
Contributor
Author
|
Thank you xD. I added some unit tests for some edge cases, just to be on the safe side. Please just run the workflows again ;) I even had a faster implementation, but that would have been a security risk, as it would use recursion. And Forwarded-For is a security header, so I didnt wanted that somebody could raise a MaxStackCall Error and poitentially crashing the service. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
after: