feat: initial#1
Conversation
| "keywords": [ | ||
| "plugin", | ||
| "helper", | ||
| "fastify" |
There was a problem hiding this comment.
| "fastify" | |
| "fastify", | |
| "openapi", | |
| "otel", | |
| "opentelemetry" |
There was a problem hiding this comment.
why openapi? just out curiosity?
|
Let me take the manifest and config from there 👍 |
5a36009 to
da0dc51
Compare
da0dc51 to
1f0230b
Compare
| [](https://github.com/fastify/otel/actions/workflows/ci.yml) | ||
|
|
||
| <!-- [](https://www.npmjs.com/package/fastify-plugin) --> | ||
|
|
||
| [](https://github.com/neostandard/neostandard) |
There was a problem hiding this comment.
In my opinion, there's no need to perpetuate these badge things on new repos. For the most part, they were designed to show CI statuses. We use GHA, so such statuses are directly integrated into the repo already (the branch will have a green or red thing with a direct link to the results).
There was a problem hiding this comment.
SGTM, I mostly took this directly from fastify-plugin to keep some sort of standard across the README; agree with you, I'll remove them away
|
Cross posting this issue for vis, in case it gets carried over open-telemetry/opentelemetry-js-contrib#2619 I'd be happy to help out with a fix once this is merged |
|
Sounds good! |
|
Still cannot merge 😅 |
|
You should be able to now. |
|
Can we issue a minor release? |
|
Go for it. |
Checklist
npm run testandnpm run benchmarkand the Code of conduct