Skip to content

fix: avoid potential code injection #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Uzlopak merged 3 commits into from
Aug 17, 2025
Merged

fix: avoid potential code injection #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1cfb8e
fix: avoid potential code injection
Fdawgs Aug 15, 2025
c174126
fix: double quoting to avoid word splitting and globbing
Fdawgs Aug 15, 2025
c5f91e2
fix: double quote to allow node_version to be expanded
Fdawgs Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions .github/workflows/plugins-benchmark-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ jobs:
benchmark:
if: ${{ github.event.label.name == 'benchmark' }}
runs-on: ubuntu-latest
env:
NPM_SCRIPT: ${{ inputs.npm-script }}
permissions:
contents: read
outputs:
Expand Down Expand Up @@ -73,10 +75,12 @@ jobs:

- name: Run benchmark ${{ inputs.pr-repo }}@${{ inputs.pr-ref }}
id: benchmark-pr
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
echo 'BENCH_RESULT_${{matrix.node-version}}<<EOF' >> $GITHUB_OUTPUT
npm run --silent ${{inputs.npm-script}} >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT
echo "BENCH_RESULT_${NODE_VERSION}<<EOF" >> "$GITHUB_OUTPUT"
npm run --silent "$NPM_SCRIPT" >> "$GITHUB_OUTPUT"
echo 'EOF' >> "$GITHUB_OUTPUT"

- name: Checkout ${{ inputs.base-repo }}@${{ inputs.base-ref }}
uses: actions/checkout@v4
Expand All @@ -91,10 +95,12 @@ jobs:

- name: Run benchmark ${{ inputs.base-repo }}@${{ inputs.base-ref }}
id: benchmark-base
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
echo 'BENCH_RESULT_${{matrix.node-version}}<<EOF' >> $GITHUB_OUTPUT
npm run --silent ${{inputs.npm-script}} >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT
echo "BENCH_RESULT_${NODE_VERSION}<<EOF" >> "$GITHUB_OUTPUT"
npm run --silent "$NPM_SCRIPT" >> "$GITHUB_OUTPUT"
echo 'EOF' >> "$GITHUB_OUTPUT"

output-benchmark:
needs: benchmark
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/plugins-ci-elasticsearch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,9 @@ jobs:
run: npm i --ignore-scripts

- name: Check Licenses
run: ${{ format('npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;{0}"', inputs.license-check-allowed-additional) }}

env:
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"
linter:
name: Lint Code
if: >
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/plugins-ci-kafka.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,9 @@ jobs:
run: npm i --ignore-scripts

- name: Check Licenses
run: ${{ format('npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;{0}"', inputs.license-check-allowed-additional) }}

env:
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"
linter:
name: Lint Code
if: >
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/plugins-ci-mongo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ jobs:
run: npm i --ignore-scripts

- name: Check Licenses
run: ${{ format('npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;{0}"', inputs.license-check-allowed-additional) }}
env:
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"

linter:
name: Lint Code
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/plugins-ci-mysql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ jobs:
run: npm i --ignore-scripts

- name: Check Licenses
run: ${{ format('npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;{0}"', inputs.license-check-allowed-additional) }}
env:
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"

linter:
name: Lint Code
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/plugins-ci-postgres.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ jobs:
run: npm i --ignore-scripts

- name: Check Licenses
run: ${{ format('npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;{0}"', inputs.license-check-allowed-additional) }}
env:
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"

linter:
name: Lint Code
Expand Down Expand Up @@ -136,15 +138,16 @@ jobs:
run: npm i

- name: CI environment setup
env:
PGPORT: ${{ job.services.postgres.ports[5432] }}
run: >
npm i node-gyp

sudo apt-get install -yqq libpq-dev postgresql-client

chmod 600 .pgpass

PGPASSFILE=.pgpass psql -h localhost -p ${{
job.services.postgres.ports[5432] }} -d postgres -c 'CREATE TABLE
PGPASSFILE=.pgpass psql -h localhost -p "$PGPORT" -d postgres -c 'CREATE TABLE
users(id serial PRIMARY KEY, username VARCHAR (50) NOT NULL);' -U
postgres

Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/plugins-ci-redis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ jobs:
run: npm i --ignore-scripts

- name: Check Licenses
run: ${{ format('npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;{0}"', inputs.license-check-allowed-additional) }}
env:
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"

linter:
name: Lint Code
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/plugins-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ jobs:
run: npm i --ignore-scripts

- name: Check Licenses
run: ${{ format('npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;{0}"', inputs.license-check-allowed-additional) }}
env:
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"

linter:
name: Lint Code
Expand Down Expand Up @@ -170,7 +172,7 @@ jobs:
git clone https://github.com/fastify/fastify.git --depth 1 &&
cd fastify &&
npm i --ignore-scripts &&
npm link $PACKAGE_NAME &&
npm link "$PACKAGE_NAME" &&
npm run unit

automerge:
Expand Down
Loading