Skip to content

refactor: move linting, dep checks, and license checks to own workflow #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fdawgs merged 1 commit into from
Aug 21, 2025
Merged

refactor: move linting, dep checks, and license checks to own workflow #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 8 additions & 66 deletions .github/workflows/plugins-ci-elasticsearch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,77 +35,19 @@ on:
type: string

jobs:
dependency-review:
name: Dependency Review
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
quality-check:
uses: ./.github/workflows/plugins-ci-quality.yml
permissions:
contents: read
steps:
- name: Check out repo
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Dependency review
uses: actions/dependency-review-action@da24556b548a50705dd671f47852072ea4c105d9 # v4.7.1

license-check:
if: >
!failure() &&
!cancelled() &&
inputs.license-check == true
name: Check Licenses
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
with:
check-latest: true
node-version: lts/*

- name: Install dependencies
run: npm i --ignore-scripts

- name: Check Licenses
env:
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"
linter:
name: Lint Code
if: >
!failure() &&
!cancelled() &&
inputs.lint == true
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: Check out repo
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
with:
check-latest: true
node-version: lts/*

- name: Install dependencies
run: npm i --ignore-scripts

- name: Lint code
run: npm run lint
secrets: inherit
with:
license-check: ${{ inputs.license-check }}
license-check-allowed-additional: ${{ inputs.license-check-allowed-additional }}
lint: ${{ inputs.lint }}

test:
name: Node.js ${{ matrix.node-version }}
needs: quality-check
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down
74 changes: 8 additions & 66 deletions .github/workflows/plugins-ci-kafka.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,77 +30,19 @@ on:
type: string

jobs:
dependency-review:
name: Dependency Review
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: Check out repo
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Dependency review
uses: actions/dependency-review-action@da24556b548a50705dd671f47852072ea4c105d9 # v4.7.1

license-check:
if: >
!failure() &&
!cancelled() &&
inputs.license-check == true
name: Check Licenses
runs-on: ubuntu-latest
quality-check:
uses: ./.github/workflows/plugins-ci-quality.yml
permissions:
contents: read
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
with:
check-latest: true
node-version: lts/*

- name: Install dependencies
run: npm i --ignore-scripts

- name: Check Licenses
env:
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"
linter:
name: Lint Code
if: >
!failure() &&
!cancelled() &&
inputs.lint == true
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: Check out repo
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
with:
check-latest: true
node-version: lts/*

- name: Install dependencies
run: npm i --ignore-scripts

- name: Lint code
run: npm run lint
secrets: inherit
with:
license-check: ${{ inputs.license-check }}
license-check-allowed-additional: ${{ inputs.license-check-allowed-additional }}
lint: ${{ inputs.lint }}

test:
name: Node.js ${{ matrix.node-version }}
needs: quality-check
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down
75 changes: 8 additions & 67 deletions .github/workflows/plugins-ci-mongo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,78 +30,19 @@ on:
type: string

jobs:
dependency-review:
name: Dependency Review
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
quality-check:
uses: ./.github/workflows/plugins-ci-quality.yml
permissions:
contents: read
steps:
- name: Check out repo
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Dependency review
uses: actions/dependency-review-action@da24556b548a50705dd671f47852072ea4c105d9 # v4.7.1

license-check:
if: >
!failure() &&
!cancelled() &&
inputs.license-check == true
name: Check Licenses
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
with:
check-latest: true
node-version: lts/*

- name: Install dependencies
run: npm i --ignore-scripts

- name: Check Licenses
env:
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"

linter:
name: Lint Code
if: >
!failure() &&
!cancelled() &&
inputs.lint == true
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: Check out repo
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
with:
check-latest: true
node-version: lts/*

- name: Install dependencies
run: npm i --ignore-scripts

- name: Lint code
run: npm run lint
secrets: inherit
with:
license-check: ${{ inputs.license-check }}
license-check-allowed-additional: ${{ inputs.license-check-allowed-additional }}
lint: ${{ inputs.lint }}

test:
name: Node.js ${{ matrix.node-version }} - ${{ matrix.db }}
needs: quality-check
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down
77 changes: 8 additions & 69 deletions .github/workflows/plugins-ci-mysql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,80 +30,19 @@ on:
type: string

jobs:
dependency-review:
name: Dependency Review
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: Check out repo
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Dependency review
uses: actions/dependency-review-action@da24556b548a50705dd671f47852072ea4c105d9 # v4.7.1

license-check:
if: >
!failure() &&
!cancelled() &&
inputs.license-check == true
name: Check Licenses
runs-on: ubuntu-latest
quality-check:
uses: ./.github/workflows/plugins-ci-quality.yml
permissions:
contents: read
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
with:
check-latest: true
node-version: lts/*

- name: Install dependencies
run: npm i --ignore-scripts

- name: Check Licenses
env:
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"

linter:
name: Lint Code
if: >
!failure() &&
!cancelled() &&
inputs.lint == true
runs-on: ubuntu-latest
permissions:
contents: read
steps:

- name: Check out repo
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
with:
check-latest: true
node-version: lts/*

- name: Install dependencies
run: npm i --ignore-scripts

- name: Lint code
if: ${{ inputs.lint == true}}
run: npm run lint
secrets: inherit
with:
license-check: ${{ inputs.license-check }}
license-check-allowed-additional: ${{ inputs.license-check-allowed-additional }}
lint: ${{ inputs.lint }}

test:
name: Node.js ${{ matrix.node-version }} - ${{ matrix.db }}
needs: quality-check
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down
Loading
Loading