Implement file upload for package parameter in put_package#7
Open
jannic wants to merge 1 commit intofastly:mainfrom
Open
Implement file upload for package parameter in put_package#7jannic wants to merge 1 commit intofastly:mainfrom
jannic wants to merge 1 commit intofastly:mainfrom
Conversation
Contributor
|
👋🏻 Thanks @jannic I appreciate you providing this working example. I'll take a look at the code-generator template and see if we can work this into there without too much disruption 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
put_packageis still not usable because the upload of the package contents isn't implemented.Of course this merge request is of limited usefulness because the fastly-api source code is generated. But perhaps it's still helpful when you improve the code generator?
For that reason I also didn't bother to replace the
unwrapcall with proper error handling.