Skip to content

Support for custom IVAs#14

Merged
bronzdoc merged 16 commits intofastruby:masterfrom
tcordeu:line_item_iva_custom
Nov 29, 2019
Merged

Support for custom IVAs#14
bronzdoc merged 16 commits intofastruby:masterfrom
tcordeu:line_item_iva_custom

Conversation

@tcordeu
Copy link
Copy Markdown

@tcordeu tcordeu commented Jul 23, 2019

AfipBill::LineItems now support custom IVAs while maintaining support for previous releases (default is 21%).

Copy link
Copy Markdown
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcordeu Thanks for submitting this! I think it looks good.

@lubc What do you think?

Copy link
Copy Markdown
Contributor

@lubc lubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcordeu Thanks for working on this! It looks great 💯

@lubc
Copy link
Copy Markdown
Contributor

lubc commented Sep 30, 2019

@tcordeu One minor comment before I merge it: Can you update de Readme file so people know that it's possible to pass a custom IVA to the LineItem? Thanks!

@bronzdoc bronzdoc merged commit 67e2092 into fastruby:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants