Use cae_due_date as CAE expire date#16
Merged
bronzdoc merged 2 commits intofastruby:masterfrom Nov 29, 2019
Merged
Conversation
added 2 commits
July 24, 2019 09:58
The expiry date of the service payment is not the same as the CAE expiry date, so it should not be used as a replacement for it.
etagwerker
reviewed
Sep 28, 2019
| ```ruby | ||
| json_bill = { | ||
| cae: "1234567890123", # CAE number | ||
| cae_due_date: "20171125", # CAE expiry date |
Member
There was a problem hiding this comment.
@tcordeu Could you point us in the right direction here? I haven't been keeping up with the latest AFIP API changes. Do you have a screenshot, sample, or link to official documentation? Trying to understand if this is a new field, or the same field (fch_vto_pago) being renamed.
If you are adding cae_due_date here, shouldn't you remove fch_vto_pago from the README?
Contributor
There was a problem hiding this comment.
@tcordeu As @etagwerker said, we should get rid of fch_vto_pago from the README.
| pto_venta: AfipBill.configuration[:sale_point], | ||
| cae: afip_bill["cae"], | ||
| vto_cae: afip_bill["fch_vto_pago"] | ||
| vto_cae: afip_bill["cae_due_date"] |
Member
lubc
reviewed
Sep 30, 2019
| ```ruby | ||
| json_bill = { | ||
| cae: "1234567890123", # CAE number | ||
| cae_due_date: "20171125", # CAE expiry date |
Contributor
There was a problem hiding this comment.
@tcordeu As @etagwerker said, we should get rid of fch_vto_pago from the README.
bronzdoc
approved these changes
Nov 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expiry date of the service payment is not the same as the CAE expiry date, so it should not be used as a replacement for it.
Generally, the CAE's expiry date is ten days away from the date of its generation.