Move bundle_report rails compatibility logic into a class #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanVqz
commented
Feb 11, 2025
JuanVqz
force-pushed
the
move-rails-version-compatibility-into-its-own-class
branch
2 times, most recently
from
61699bf to
7f7a9df
Compare
JuanVqz
force-pushed
the
move-rails-version-compatibility-into-its-own-class
branch
from
b8e927b to
74e4bf6
Compare
JuanVqz
force-pushed
the
move-rails-version-compatibility-into-its-own-class
branch
2 times, most recently
from
bb757ad to
8f93530
Compare
JuanVqz
force-pushed
the
move-rails-version-compatibility-into-its-own-class
branch
3 times, most recently
from
04e5134 to
e8c5911
Compare
Member
Author
|
@arielj any chances you can review this, please? |
JuanVqz
force-pushed
the
move-rails-version-compatibility-into-its-own-class
branch
6 times, most recently
from
d7e4eb5 to
aa6053d
Compare
I extracted it into a class because I think it will be easier to use the `incompatible_gems_by_state` data there. Based on the code review
JuanVqz
force-pushed
the
move-rails-version-compatibility-into-its-own-class
branch
3 times, most recently
from
80a1716 to
078903a
Compare
arielj
requested changes
Mar 5, 2025
arielj
left a comment
arielj
left a comment
There was a problem hiding this comment.
I only have that comment about the test that I think is not testing what it's meant to test, but the rest looks fine to me
Member
Author
|
@arielj, test updated! could you please approve and merge? |
Co-authored-by: Ariel <ariel@ombulabs.com>
JuanVqz
force-pushed
the
move-rails-version-compatibility-into-its-own-class
branch
from
d1da583 to
550793d
Compare
Member
Author
|
Since the requested change by @arielj was only for the test output. (if this hasn't been approved), I will merge the PR at the end of the day to unblock another work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I extracted it into its own class
Motivation and Context
I think it will be easier to understand the
BundleReport.compatibilitymethod and its usagealso I will need to use data from the
incompatible_gems_by_statemethod in another code.How Has This Been Tested?
There was an existing test case for the
erb_outputmethod, and I run it locally to make sure it still works.Screenshots:
I will abide by the code of conduct