Add next_rails --init to replace next --init #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanVqz
force-pushed
the
add-next_rails--init-command
branch
from
27de792 to
2896b55
Compare
1. I added a message to deprecate the current `next --init` command (eventually, we should remove it). 2. Moved the `next --init` functionality into the `NextRails::Init` class 3. Still need to move the `bundle exec next` functionallity. (next step? depends on the acceptance of this PR). Closes #113
JuanVqz
force-pushed
the
add-next_rails--init-command
branch
from
2896b55 to
d678853
Compare
etagwerker
approved these changes
Feb 19, 2025
Member
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@JuanVqz This looks good to me, but I'd like you to use fakefs in the tests. Could you please look into that?
Member
Author
@etagwerker I like the idea of using the fakefs gem; however, if we are planning on supporting older Ruby versions (2.0, 2.3, etc...), it would be complicated, the early fakefs v0.14.0 was already requiring Ruby So, do you think we should still wanting to include that gem? |
Member
|
Oh good point. Then I think it's okay to skip it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
next --initcommand(eventually, we should remove it).
next --initfunctionality into theNextRails::Initclassbundle exec nextfunctionallity. (next step? depends on the acceptance of this PR).Motivation and Context
If the user has the
nextcommand installed fromnpm install -g next, thenext --initcommand will not work.This is a problem because the user will not know how to call the
nextcommand.It is reported here:
Closes #113
How Has This Been Tested?
next --initcommand and checking that the message is displayed.NextRails::Initclass.Screenshots:
Added a deprecation warning when running
next --initWhen the command creates the
Gemfile.nextandGemfile.next.lockit shows the same message asnext --inithas been showing:If the
next_rails --initgem was run previously and theGemfile.nextandGemfile.next.lockalready exist it does not run the command and shows a message instead.Now the
--initcommand is part of the--helpoutputI will abide by the code of conduct