Merged
Conversation
mattoc
reviewed
Apr 4, 2024
| let!(:valid_payload) {{ | ||
| async: false | ||
| 'async' => false | ||
| }} |
Author
There was a problem hiding this comment.
No dice with this, I then stumble here:
1) FatZebra::Utilities::ApplePay::Domain.register! creates the domain
Failure/Error: payload[:test] = true if configurations.test_mode
TypeError:
no implicit conversion of Symbol into Integer
# ./lib/fat_zebra/api_resource.rb:29:in `[]='
# ./lib/fat_zebra/api_resource.rb:29:in `request'
# ./lib/fat_zebra/utilities/apple_pay/domain.rb:33:in `register!'
# ./spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb:27:in `block (3 levels) in <top (required)>'
# ./spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb:35:in `block (3 levels) in <top (required)>'
Author
There was a problem hiding this comment.
Updated options to be positional arg to keep invocation consistent with rest of gem.
mattoc
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.