Skip to content

Fix failing spec#47

Merged
mattoc merged 2 commits intofatzebra:masterfrom
AV-room:fix-failing-spec
Apr 8, 2024
Merged

Fix failing spec#47
mattoc merged 2 commits intofatzebra:masterfrom
AV-room:fix-failing-spec

Conversation

@AV-room
Copy link

@AV-room AV-room commented Apr 4, 2024

No description provided.

let!(:valid_payload) {{
async: false
'async' => false
}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try .to_json on this Hash?

Copy link
Author

@AV-room AV-room Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No dice with this, I then stumble here:

1) FatZebra::Utilities::ApplePay::Domain.register! creates the domain
     Failure/Error: payload[:test] = true if configurations.test_mode

     TypeError:
       no implicit conversion of Symbol into Integer
     # ./lib/fat_zebra/api_resource.rb:29:in `[]='
     # ./lib/fat_zebra/api_resource.rb:29:in `request'
     # ./lib/fat_zebra/utilities/apple_pay/domain.rb:33:in `register!'
     # ./spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb:27:in `block (3 levels) in <top (required)>'
     # ./spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb:35:in `block (3 levels) in <top (required)>'

Copy link
Author

@AV-room AV-room Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated options to be positional arg to keep invocation consistent with rest of gem.

@mattoc mattoc merged commit de993a4 into fatzebra:master Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants