Fix table restoration for compacted changelogs#373
Conversation
|
@elrik75 how about giving this a try? Apparently the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #373 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 102 102
Lines 11100 11100
Branches 1196 1196
=======================================
Hits 10444 10444
Misses 557 557
Partials 99 99 ☔ View full report in Codecov by Sentry. |
|
We'll need to test this further before merging. |
|
I reviewed the code and the problem is much deeper than the changes here. |
|
This bug still exists. I recently lost my rocks-db disk and Faust started and launched the recovery. Once again some changelogs partitions did not start (they have an offset equal to the first Kafka offset - 1). Removing the |
|
In that case, I'll reopen the PR as a reminder for me to investigate this. |
Fixes #176.